Catch error in write to remove broken file #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the write command errors it still sometimes construct a broken file on disk.
This change should make sure, that the write function would tidy up these broken files after faliure, because they are in the way for later analysis.
Do you think, that this is enough to capture all broken files?
Should this also be tested for other backends?
Locally I get some spurious failures which have nothing to do with the changes but are coming from some download time out errors.