fix: sonar issues

raffreitas · Dec 30, 2024 · 9bc3dd0 · 9bc3dd0
1 parent b29aa0f
commit 9bc3dd0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 16 deletions.
diff --git a/src/MyRecipes.API/BackgroudServices/DeleteUserService.cs b/src/MyRecipes.API/BackgroudServices/DeleteUserService.cs
@@ -37,13 +37,4 @@ private async Task ProcessMessageAsync(ProcessMessageEventArgs eventArgs)
     }
 
     private static Task ExceptionReceivedHandler(ProcessErrorEventArgs _) => Task.CompletedTask;
-
-    ~DeleteUserService() => Dispose();
-
-    public override void Dispose()
-    {
-        base.Dispose();
-
-        GC.SuppressFinalize(this);
-    }
 }
diff --git a/src/MyRecipes.Application/UseCases/Recipe/Generate/GenerateRecipeValidator.cs b/src/MyRecipes.Application/UseCases/Recipe/Generate/GenerateRecipeValidator.cs
@@ -1,4 +1,5 @@
 using FluentValidation;
+
 using MyRecipes.Communication.Requests;
 using MyRecipes.Domain.ValueObjects;
 using MyRecipes.Exceptions;
@@ -31,7 +32,6 @@ public GenerateRecipeValidator()
                 if (value.Count(c => c == ' ') > 3 || value.Count(c => c == '/') > 1)
                 {
                     context.AddFailure("Ingredient", ResourceMessagesExceptions.INGREDIENT_NOT_FOLLOWING_PATTERN);
-                    return;
                 }
             });
         });

diff --git a/src/MyRecipes.Infrastructure/DependencyInjectionExtension.cs b/src/MyRecipes.Infrastructure/DependencyInjectionExtension.cs
@@ -109,11 +109,10 @@ private static void AddPasswordEncripter(IServiceCollection services)
 
     private static void AddOpenAI(IServiceCollection services, IConfiguration configuration)
     {
-        const string CHAT_MODEL = "gpt-4o";
         var apiKey = configuration.GetValue<string>("Settings:OpenAI:ApiKey");
 
-        services.AddScoped<IGenerateRecipeAI, ChatGPTService>();
-        services.AddScoped(_ => new ChatClient(model: CHAT_MODEL, apiKey: apiKey));
+        services.AddScoped<IGenerateRecipeAI, ChatGptService>();
+        services.AddScoped(_ => new ChatClient(model: "gpt-4o", apiKey: apiKey));
     }
 
     private static void AddStorage(IServiceCollection services, IConfiguration configuration)

diff --git a/src/MyRecipes.Infrastructure/Services/OpenAI/ChatGPTService.cs b/src/MyRecipes.Infrastructure/Services/OpenAI/ChatGPTService.cs
@@ -1,14 +1,15 @@
 using MyRecipes.Domain.Dtos;
 using MyRecipes.Domain.Enums;
 using MyRecipes.Domain.Services.OpenAi;
+
 using OpenAI.Chat;
 
 namespace MyRecipes.Infrastructure.Services.OpenAI;
-internal class ChatGPTService : IGenerateRecipeAI
+internal class ChatGptService : IGenerateRecipeAI
 {
     private readonly ChatClient _chatClient;
 
-    public ChatGPTService(ChatClient chatClient) => _chatClient = chatClient;
+    public ChatGptService(ChatClient chatClient) => _chatClient = chatClient;
 
     public async Task<GeneratedRecipeDto> Generate(IList<string> ingredients)
     {
@@ -18,7 +19,7 @@ public async Task<GeneratedRecipeDto> Generate(IList<string> ingredients)
             new UserChatMessage(string.Join(';', ingredients))
         ];
 
-        var completion = await _chatClient.CompleteChatAsync();
+        var completion = await _chatClient.CompleteChatAsync(messages);
 
         var responseList = completion.Value.Content[0].Text
             .Split("\n")