Move start session to thread #26
Conversation
Co-authored-by: Howard Gil <[email protected]>
🔍 Code Review Summary❗ Attention Required: This push has potential issues. 🚨 Overview
🚨 Critical Issuessecurity (2 issues)1. Potential exposure of sensitive information in logs.📁 File: agentops/session.py 💡 Solution: Current Code: logger.error(f"Could not start session - server could not authenticate your API Key")Suggested Code: logger.error("Could not start session - server could not authenticate the API Key")2. Potential performance issue due to unnecessary sleep calls.📁 File: tests/test_pre_init.py 💡 Solution: Current Code: time.sleep(1)Suggested Code: # Replace with an asynchronous wait or event-driven logic
Useful Commands
|
![kaizen-bot[bot]](https://avatars.githubusercontent.com/in/480502?s=60&v=4){kind=small}
| return False | ||
|
|
||
| jwt = res.body.get("jwt", None) | ||
| self.jwt = jwt | ||
| if jwt is None: | ||
| logger.error( | ||
| f"Could not start session - server could not authenticate your API Key" |
There was a problem hiding this comment.
Comment: Potential exposure of sensitive information in logs.
Solution: Review logging statements to ensure sensitive information is not included.
!! Make sure the following suggestion is correct before committing it !!
| f"Could not start session - server could not authenticate your API Key" | |
| logger.error("Could not start session - server could not authenticate the API Key") |
| @@ -48,10 +48,20 @@ def test_track_agent(self, mock_req): | |||
| assert len(mock_req.request_history) == 0 | |||
|
|
|||
| agentops.init(api_key=self.api_key) | |||
| time.sleep(1) | |||
There was a problem hiding this comment.
Comment: Potential performance issue due to unnecessary sleep calls.
Solution: Consider using asynchronous programming or event-driven architecture to handle waiting without blocking.
!! Make sure the following suggestion is correct before committing it !!
| time.sleep(1) | |
| # Replace with an asynchronous wait or event-driven logic |
📥 Pull Request
📘 Description
Briefly describe the changes you've made.
🧪 Testing
Describe the tests you performed to validate your changes.