-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogen latency v2 #31
base: main
Are you sure you want to change the base?
Changes from all commits
4ce6f80
6b37e1a
f4d8347
b1130ea
501384c
e19d56d
1b8f473
c0fa6bb
ca2bfe4
20d496d
f88304f
ea8bbc0
47e21fa
6b6e13a
a731160
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -47,13 +47,11 @@ def get_sys_packages(): | |||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
def get_installed_packages(): | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
try: | ||||||||||||||||||||||||||||||||
return { | ||||||||||||||||||||||||||||||||
# TODO: test | ||||||||||||||||||||||||||||||||
# TODO: add to opt out | ||||||||||||||||||||||||||||||||
"Installed Packages": { | ||||||||||||||||||||||||||||||||
dist.metadata["Name"]: dist.version | ||||||||||||||||||||||||||||||||
dist.metadata.get("Name"): dist.metadata.get("Version") | ||||||||||||||||||||||||||||||||
for dist in importlib.metadata.distributions() | ||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||
Comment on lines
47
to
57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ℹ️ Logic ErrorEnsure Default Values for Metadata RetrievalThe change from - dist.metadata.get("Name"): dist.metadata.get("Version")
+ dist.metadata.get("Name", "Unknown"): dist.metadata.get("Version", "0.0.0") Commitable Code Suggestion:
Suggested change
|
||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Performance Improvement
Optimize Badge Images for Performance
The update to use badge images for social links in the README.md file enhances the visual appeal and provides a more interactive experience for users. However, ensure that the badge images are optimized for performance to prevent any unnecessary loading delays, especially on slower connections.