Use the default SolidCache::Record role #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmb
force-pushed
the
enforce-default-role
branch
4 times, most recently
from
3dbbb72 to
718146f
Compare
Don't let the ActiveRecord::Base role bleed into the SolidCache connections. Also ensure that writes are not prevented. We'll always set up the shard if configured as we may be pointing to the default shard but with the wrong role and prevent writes setting.
djmb
force-pushed
the
enforce-default-role
branch
from
718146f to
8cbf8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let the ActiveRecord::Base role bleed into the SolidCache connections. This is a problem when the default role is :reading and the SolidCache connection does not have a value set.