Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up from automatically selecting a service #456

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Milo123459
Copy link
Collaborator

@Milo123459 Milo123459 commented Oct 10, 2023

Previously, up and logs would pick a service if only one service was in the linked project. This often caused unwanted behaviour, so this PR changes it to a prompt.

Relevant thread: https://discord.com/channels/713503345364697088/1160376027365785711

@Milo123459 Milo123459 added the release/patch Author patch release label Oct 10, 2023
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@coffee-cup coffee-cup merged commit e24a0a1 into master Oct 19, 2023
6 checks passed
@coffee-cup coffee-cup deleted the milo/fix-up-honestly branch October 19, 2023 04:54
@GrantBirki
Copy link
Contributor

GrantBirki commented Feb 8, 2024

@coffee-cup + @Milo123459 just something to bring to your attention in regards to this being a patch change. This change actually broke all of our deployments. Our CI systems were not passing in the --service flag and our projects only had one service in each. For our production deployments, we actually have to commit changes to main for our CI system to pick these up. This lead to deployments failing with the following error message:

Multiple services found. Please specify a service to deploy to via the --service flag.

By removing the if services.len() == 1 statement in this pull request, you effectively made the --service flag a required argument when using railway up and this should be considered a breaking change as existing commands / deployments would now fail without this parameter.

My ask is that in the future, a little more thought is put into how these changes may impact CI systems and not just users running these commands. Broken build / deployment systems is something no one wants when bumping a dependency by a single patch level.

I still love railway btw but I just wanted to provide some constructive feedback about this issue that our team faced

Thanks! 🙇 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/patch Author patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants