Optimize backendNetworks store #6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why there were two instances of <BackendNetworks />
walmat
reviewed
Jan 21, 2025
| @@ -154,7 +153,7 @@ const getInitialSliderXPosition = ({ | |||
| export const SwapProvider = ({ children }: SwapProviderProps) => { | |||
| const { nativeCurrency } = useAccountSettings(); | |||
|
|
|||
| const backendNetworks = useBackendNetworksStore(state => state.backendNetworksSharedValue); | |||
| const [nativeChainAssets] = useState(useBackendNetworksStore.getState().getChainsNativeAsset()); | |||
There was a problem hiding this comment.
any reason to not use useRef here?
walmat
reviewed
Jan 21, 2025
| @@ -97,6 +98,13 @@ export const TokenToBuyList = () => { | |||
| const { internalSelectedInputAsset, internalSelectedOutputAsset, isFetching, isQuoteStale, outputProgress, setAsset } = useSwapContext(); | |||
| const { results: sections, isLoading } = useSearchCurrencyLists(); | |||
|
|
|||
| const [supportedChainsBooleanMap] = useState( | |||
There was a problem hiding this comment.
any reason not to use useRef here?
There was a problem hiding this comment.
I think it's mostly a semantic choice, seems a bit cleaner to use useState since you can omit the setter, making it closer to naturally read only, and with useState you don't need to deal with .current.
There was a problem hiding this comment.
Sounds reasonable to me. Was just curious!
walmat
approved these changes
Jan 21, 2025
derHowie
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
backendNetworksstore methods are called thousands of times — this cuts total function execution time by ~95%+~97.5ms🔴~3.3ms🟢createQueryStoreand removes the<BackendNetworks />sync component, which existed in two placesScreen recordings / screenshots
What to test