Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old search resource in favor of searchV2 resource #6464

Draft
wants to merge 105 commits into
base: develop
Choose a base branch
from
Draft

Remove old search resource in favor of searchV2 resource #6464

wants to merge 105 commits into from

Conversation

jinchung
Copy link
Member

@jinchung jinchung commented Feb 19, 2025 •
edited
Loading

Fixes APP-####

What changed (plus any additional context for devs)

  1. Moved over handlers/deeplinks and ClaimCustomization that was still using search/search to now use Christian's new search/searchV2.
  2. Move DiscoverSearch to searchV2
  3. Deleted search/search

Screen recordings / screenshots

What to test

  • Test Discover search results behave as expected
  • Test deeplink handling for the swaps URL flow that it still behaves as expected
  • Test claiming USDC on different networks still works as part of the claim customization flow

@christianbaroni
Add createRemoteRainbowStore
6dd30ee
@christianbaroni
Fix import path
68101ed
@christianbaroni
Improve types, rename to createRainbowQueryStore
8a48827
@christianbaroni
Clean up createRainbowStore
c8121cb
@christianbaroni
Ensure internal state is persisted when partialize is used, remove an…
3fa324f 
…y types
@christianbaroni
Make createBlendedPartialize faster, improve typing
938c7de
@christianbaroni
Improve persist map readability
4a6fc53
@christianbaroni
Add dynamic params, API cleanup
d2c0061
@christianbaroni
Misc. cleanup
eef9903
@christianbaroni
Add time utility
96d8fd4
@christianbaroni
Guard console.log
0b59554
@christianbaroni
Merge remote-tracking branch 'origin/develop' into @christian/remote-…
9966fa2 
…rainbow-store
@christianbaroni
Add setData, clean up caching and staleTime logic, rename to createQu…
c02515d 
…eryStore
@christianbaroni
Use consistent store naming
a8d4c73
@christianbaroni
Improve error handling, add getStatus(), reduce type redundancy, omit…
7dbb6ef 
… store methods from persisted state
@christianbaroni
[createRainbowStore] Support maps and sets internally
2f86899
@christianbaroni
Allow dynamic params for internal state: ($, store) => $(store).state
791757e
@christianbaroni
[createRainbowStore] Catch up with develop
11f8fdf
@christianbaroni
Merge remote-tracking branch 'origin/develop' into @christian/remote-…
5d9d5c4 
…rainbow-store
@christianbaroni
Remove unnecessary assignment
61e97f4
@christianbaroni
Minor docs cleanup
fda20e2
@christianbaroni
Split types to better obscure private internal state
96a12a7
@christianbaroni
Fix cache overwriting, expose and track queryKey, improve setData d…
a1d1b45 
…ocs, add overloads, misc. fixes
@christianbaroni
Fix signal logging
8b11f97
@christianbaroni
Merge remote-tracking branch 'origin/develop' into @christian/remote-…
b8c4a3c 
…rainbow-store
@christianbaroni
Organize types, skip string conversion if unneeded in getOrCreateAtta…
c677ad2 
…chValue
@christianbaroni
Merge branch 'develop' into @christian/remote-rainbow-store
b969de5
@christianbaroni
Add AbortController, abortInterruptedFetches setting (default true)
c898f97
@christianbaroni
Ensure effectiveParams and currentQueryKey are always in sync within …
a6f8998 
…each fetch operation
@christianbaroni
Improve logging, fix error handling, improve param equality check acc…
055cdd4 
…uracy, make fetch return data, expose params to transform, misc. optimizations
jinchung and others added 26 commits February 6, 2025 09:43
@jinchung
Reintroduce support for crosschain search results in swaps search (#6440
5651f36 
)

* Remove unused fromChainId param from search request

* Remove unnecessary threshold param from search request

* Remove unnecessary keys param from search request

* Consolidate verified and unverified results

* Consolidate and set results for crosschain, verified, unverified assets

* Cap max crosschain results to 3

* Consolidate address search vs normal query search
@jinchung
Fixup: hook up discover search query store
107de3d
@jinchung
Fixup: hook up useSearchCurrencyList to discovery query store
661ba9b
@jinchung
Read searchQuery from store in DiscoverSearchInput
52ca425
@jinchung
Read searchQuery from store in DiscoverSearch
14e9573
@jinchung
Use setSearchQuery from query store
2a8076d
@jinchung
Fixup: clean up logger error message in new discover search query fun…
c4da7e4 
…ction
@jinchung
Hook up isLoading in DiscoverSearchInput from discover search store
c4ab122
@jinchung
Hook up isLoading in DiscoverSearch from discover search store
cbf97f1
@jinchung
Remove setIsLoading manually from DiscoverScreenContext
f93a737
@jinchung
Hook up isSearching flag from discover search query store
cb45c3e
@jinchung
Move out isFetchingEns from DiscoverScreenContext
e184df4
@jinchung
Remove analytics tracking on cancel from Context which was causing a …
0af6656 
…lot of unnecessary rerenders
@jinchung
Update parser for discover token search to dedupe across networks
f4acf10
@jinchung
Filter out favorites and cap max results in discover search results
9b35d12
@christianbaroni
Re-split verified and unverified search, remove deleted file, misc. c…
fbbbaf2 
…leanup
@christianbaroni
Clean up search utils
0c116db
@christianbaroni
Merge remote-tracking branch 'origin/develop' into @christian/query-s…
6724f10 
…tore-token-search
@christianbaroni
Hook up list refs to ChainSelection component
1b79e78
@christianbaroni
Update old parseTokenSearch imports
d854f0a
@christianbaroni
Clean up SearchInput component
7ddb87c
@christianbaroni
Disable Discover search data persistence
bae69a1
@christianbaroni
Skip applying shadowColor to coin icons when disableShadow: true …
d9aec26 
…is set
@christianbaroni
[Discover] Extract ExchangeAssetSectionListHeader so it's not repea…
4b89a62 
…tedly recreated
@christianbaroni
[TokenToSellList] Increase initialNumToRender to accommodate taller…
4b14679 
… screens
@jinchung
Merge branch '@christian/query-store-token-search' into @jin/swap-sea…
91e6fc3 
…rch-over-query-store
@jinchung jinchung force-pushed the @jin/swap-search-over-query-store branch from d607ea5 to 91e6fc3 Compare February 19, 2025 22:07
@jinchung jinchung changed the title @jin/swap search over query store Remove old search resource in favor of searchV2 resource Feb 21, 2025
Base automatically changed from @christian/query-store-token-search to develop February 28, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinchung @christianbaroni @ibrahimtaveras00