-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Switcher Implementations #6466
Open
walmat
wants to merge
16
commits into
develop
Choose a base branch
from
@matthew/network-switcher
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…works as possible
ibrahimtaveras00
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on both OS's, QA passed 👍🏽
maxbbb
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2341, APP-2342, APP-2343, APP-2344, APP-2345, APP-2346
What changed (plus any additional context for devs)
With our growing list of networks, we need to enable scrolling on the network switcher to prevent the sheet from overflowing off the top of the screen.
Swaps now will utilize the new NetworkSwitcher route to change output / input token lists. The token to sell list is filtered down show networks that the user has tokens on. Output is sorted by balance. This is the same functionality as we had before in the dropdown menus.
Adds a variant of NetworkSwitcher to the WalletConnectApprovalSheet. We needed to add the following functionality (or rather remove?)
Added NetworkSelectorButton component to provide a reusable way to launch into a NetworkSelector route. I also cleaned up a little bit of the file system by moving the NetworkSelector to the screens folder since it's a route.
Biggest most notable change which is what the ticket is for, is introducing actionButton prop into the NetworkSelector route. It provides overrides to turn the All Networks masthead button into a configurable action button as shown in the below screen recording.
Adds the Network Selector component to the preferred network selection.
Claimables customization network selector now uses the new network selector.
Screen recordings / screenshots
See individual PRs:
#6454
#6455
#6456
#6457
#6458
#6459
What to test
All locations should behave as expected