Fix: createQueryStore not setting subscription manager to enabled #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
removed
the
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Noticed there was an edge case where a queryStore would begin disabled and not be triggered to enabled when it should. This fixes it.
There still exists an edge case if the
enabledselector andparamsrely on the same piece of state that we don't update the enabled state before the params, so we end up triggering a fetch that's guaranteed to fail via abort. Not a huge deal, but should be addressed at some point in the future.Screen recordings / screenshots
n/a
What to test
I'll throw up a mock here in a bit