Skip to content

Commit

Permalink
Merge pull request #24 from rainforestapp/2.5-support
Browse files Browse the repository at this point in the history
Blind update to 2.5
  • Loading branch information
kruszczynski authored Sep 14, 2018
2 parents 8bfda3b + a088d0c commit 7b7c8b7
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
jobs:
push_to_rubygems:
docker:
- image: circleci/ruby:2.4.4
- image: circleci/ruby:2.5.1
steps:
- checkout
- run:
Expand Down
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
language: ruby
rvm:
- 2.3.0
- 2.5.1
- 2.4.4
before_install: gem install bundler -v 1.10.6
2 changes: 1 addition & 1 deletion lib/rf/stylez/version.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true
module Rf
module Stylez
VERSION = '0.2.9'
VERSION = '0.2.10'
end
end
2 changes: 1 addition & 1 deletion rf-stylez.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

spec.add_runtime_dependency 'rubocop', '~> 0.51.0'
spec.add_runtime_dependency 'rubocop', '~> 0.59.0'

spec.add_development_dependency 'bundler', '~> 1.10'
spec.add_development_dependency 'rake', '~> 10.0'
Expand Down
20 changes: 17 additions & 3 deletions ruby/rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
AllCops:
TargetRubyVersion: 2.3
TargetRubyVersion: 2.5
DisabledByDefault: true
Include:
- '**/*.rb'
- '**/*.rake'
- '**/Rakefile'
- '**/config.ru'
- '**/Guardfile'
- '**/*.ru'
- '**/Gemfile'
Exclude:
- 'db/**/*'
Expand All @@ -14,6 +17,14 @@ inherit_from:
./rubocop_lint.yml

# Good style cops
Layout/BlockAlignment:
Enabled: true
Layout/EndAlignment:
Enabled: true
Layout/DefEndAlignment:
Enabled: true
Layout/ConditionPosition:
Enabled: true
Layout/TrailingBlankLines:
Enabled: true
Layout/TrailingWhitespace:
Expand Down Expand Up @@ -110,7 +121,10 @@ Style/RedundantFreeze:
Style/TrailingCommaInArguments:
Enabled: true
EnforcedStyleForMultiline: no_comma
Style/TrailingCommaInLiteral:
Style/TrailingCommaInArrayLiteral:
Enabled: true
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInHashLiteral:
Enabled: true
EnforcedStyleForMultiline: consistent_comma
Style/MultilineIfThen:
Expand Down
21 changes: 1 addition & 20 deletions ruby/rubocop_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,14 @@ Lint/AssignmentInCondition:
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition'
Enabled: true

Lint/BlockAlignment:
Description: 'Align block ends correctly.'
Enabled: true

Lint/CircularArgumentReference:
Description: "Default values in optional keyword arguments and optional ordinal arguments should not refer back to the name of the argument."
Enabled: true

Lint/ConditionPosition:
Description: >-
Checks for condition placed in a confusing position relative to
the keyword.
StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
Enabled: true

Lint/Debugger:
Description: 'Check for debugger calls.'
Enabled: true

Lint/DefEndAlignment:
Description: 'Align ends corresponding to defs correctly.'
Enabled: true

Lint/DeprecatedClassMethods:
Description: 'Check for deprecated class method calls.'
Enabled: true
Expand Down Expand Up @@ -67,10 +52,6 @@ Lint/EmptyInterpolation:
Description: 'Checks for empty string interpolation.'
Enabled: true

Lint/EndAlignment:
Description: 'Align ends correctly.'
Enabled: true

Lint/EndInMethod:
Description: 'END blocks should not be placed inside method definitions.'
Enabled: true
Expand Down Expand Up @@ -176,7 +157,7 @@ Lint/UnderscorePrefixedVariableName:
Description: 'Do not use prefix `_` for a variable that is used.'
Enabled: true

Lint/UnneededDisable:
Lint/UnneededCopDisableDirective:
Description: >-
Checks for rubocop:disable comments that can be removed.
Note: this cop is not disabled when disabling all cops.
Expand Down

0 comments on commit 7b7c8b7

Please sign in to comment.