nccl headers: Fail if type unknown

Fail compilation if neither definition was found rather than having a fall-through case. Signed-off-by: Raghu Raja <[email protected]>
rajachan · Mar 30, 2024 · b13a103 · b13a103
1 parent d91e9bf
commit b13a103
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/include/nccl-headers/error.h b/include/nccl-headers/error.h
@@ -1,14 +1,16 @@
 /*
- * Copyright (c)      2023 Amazon.com, Inc. or its affiliates. All rights reserved.
+ * Copyright (c) 2023-2024 Amazon.com, Inc. or its affiliates. All rights reserved.
  */
 
 #ifndef NCCL_HEADERS_ERROR_H
 #define NCCL_HEADERS_ERROR_H
 
 #if HAVE_CUDA
 #include "nccl-headers/nvidia/err.h"
-#else
+#elif HAVE_NEURON
 #include "nccl-headers/neuron/error.h"
+#else
+#error "Neither CUDA nor Neuron support is available"
 #endif
 
 #endif
diff --git a/include/nccl-headers/net.h b/include/nccl-headers/net.h
@@ -1,14 +1,16 @@
 /*
- * Copyright (c)      2023 Amazon.com, Inc. or its affiliates. All rights reserved.
+ * Copyright (c) 2023-2024 Amazon.com, Inc. or its affiliates. All rights reserved.
  */
 
 #ifndef NCCL_HEADERS_NET_H
 #define NCCL_HEADERS_NET_H
 
 #if HAVE_CUDA
 #include "nccl-headers/nvidia/net.h"
-#else
+#elif HAVE_NEURON
 #include "nccl-headers/neuron/net.h"
+#else
+#error "Neither CUDA nor Neuron support is available"
 #endif
 
 #endif