Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP of DWX module updates #1

Open
wants to merge 25 commits into
base: cdw-level-2
Choose a base branch
from

Conversation

wmudge
Copy link

@wmudge wmudge commented Aug 11, 2021

Mainly updates to the documentation to get it to auto-generate correctly. NOTE: I have not yet tackled the logic/code within dw_virtual_warehouse.

@wmudge wmudge marked this pull request as ready for review August 17, 2021 18:07
@wmudge
Copy link
Author

wmudge commented Aug 17, 2021

Still needs testing, but is ready for that

@wmudge
Copy link
Author

wmudge commented Aug 19, 2021

Did a bunch of testing and added some further modules to complete the set. Always could use more testing though!

FYI, I reposted this branch as a separate PR, thinking that we might commit it today, but that window has closed now. So, we can either look at incorporating this PR to your branch (and thus would update the cloudera.cloud PR) or close your cloudera.cloud PR and use the new, separate PR that I mentioned. Either way, the results (and commits) are the same -- we just need to make sure that the cdpy updates are committed as well.

@raju-saravanan
Copy link
Owner

@wmudge: Thanks for your efforts! I will close the my original PR and let's go ahead with yours.

wmudge and others added 25 commits August 23, 2021 17:13
Signed-off-by: Saravanan Raju <[email protected]>
Signed-off-by: Saravanan Raju <[email protected]>
Signed-off-by: Saravanan Raju <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Issue violations as discrete array in returned error
Add check for verbosity or debug to SDK warnings handler

Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Update deletion states and process
Update log messaging

Signed-off-by: Webster Mudge <[email protected]>
Update module parameter requirements
Update log messaging

Signed-off-by: Webster Mudge <[email protected]>
Remove 'name' parameter
Refactor remaining parameters for aliases and requirements

Signed-off-by: Webster Mudge <[email protected]>
@wmudge wmudge force-pushed the wmudge/feature/cdw-level-2 branch from 34fc07a to 1302819 Compare September 16, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants