cleanup: Changes for c++17 #1376
Open
+25
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleanup adjusts the rTorrent code to comply with c++17 standard. It also simplifies various parts of the code.
rakshasa
reviewed
Jan 16, 2025
| return c == '\n' || c == '\0' || c == ';'; | ||
| } | ||
| }; | ||
| bool command_map_is_space(char c) { |
rakshasa
reviewed
Jan 16, 2025
| @@ -150,7 +142,7 @@ parse_command(target_type target, const char* first, const char* last) { | |||
| // Find the last character that is part of this command, skipping | |||
| // the whitespace at the end. This ensures us that the caller | |||
| // doesn't need to do this nor check for junk at the end. | |||
| first = std::find_if(first, last, std::not1(command_map_is_space())); | |||
| first = std::find_if(first, last, [&](char c) { return !command_map_is_space(c); }); | |||
|
|
|||
| if (first != last) { | |||
| if (*first != '\n' && *first != ';' && *first != '\0') | |||
There was a problem hiding this comment.
This if statement should be !command_map_is_newline(*first), the function above you deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup adjusts the rTorrent code to comply with c++17 standard. It also simplifies various parts of the code.