Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing investigation parameter labels #1693

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

louise-davies
Copy link
Member

Description

See title. When testing DLS preprod with v2 he raised that there was a missing investigations.details.parameters.no_parameters label. So filling in that missing label and a related label I noticed was missing.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (20091c4) to head (ae7fce6).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1693   +/-   ##
========================================
  Coverage    95.39%   95.39%           
========================================
  Files          183      183           
  Lines         7932     7932           
  Branches      2535     2533    -2     
========================================
  Hits          7567     7567           
  Misses         330      330           
  Partials        35       35           
Flag Coverage Δ
common 94.27% <ø> (ø)
dataview 97.32% <ø> (ø)
download 96.03% <ø> (ø)
search 93.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies merged commit 8bc47cb into develop Feb 3, 2025
10 checks passed
@louise-davies louise-davies deleted the bugfix/fix-missing-labels branch February 3, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants