Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separator to custom toc + styling adjustments for sublist dropdown #528

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Jan 7, 2025

Related Item(s)

#520

Changes

  • Add separators for horizontal custom ToC
  • Adjust styling (remove top and bottom border, add margin) for sublist dropdown menu

This change is Reviewable

@yileifeng yileifeng added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

@yileifeng yileifeng force-pushed the custom-toc-separator branch from 353caf6 to f9bbba2 Compare January 7, 2025 18:39
Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@spencerwahl spencerwahl merged commit 01c5ac6 into ramp4-pcar4:main Jan 7, 2025
3 checks passed
@yileifeng yileifeng deleted the custom-toc-separator branch January 8, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants