-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeslider support for date fields #534
Conversation
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/timeslider-formats/#/en/00000000-0000-0000-0000-000000000000 |
27e8b77
to
7ad199c
Compare
Updated to add schema changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)
7ad199c
to
34247c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undid test config changes
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @RyanCoulsonCA and @yileifeng)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)
Related Item(s)
https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/121
Changes
date
formatter option to timesliderarcgisDate
option to timeslider to convert slider value to arcgis format for queriesNotes
date
formatterarcgisDate
option flags for conversion to arcgis format eg:TIMESTAMP '2025-01-17 00:00:00'
Testing
Steps:
Like the other formatting PR the layer doesnt match with any of these values so expect nothing on the map. I tested the actual querying thoroughly with project specific layers.
This change is