Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve captainhook validation error message #101

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

nick-lai
Copy link
Contributor

@nick-lai nick-lai commented Feb 6, 2025

Closes #55

Before:
before

After:
after

@nick-lai nick-lai marked this pull request as ready for review February 6, 2025 03:59
@nick-lai nick-lai requested a review from ramsey as a code owner February 6, 2025 03:59
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (4cdef30) to head (f9e3f83).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #101   +/-   ##
=========================================
  Coverage     98.14%   98.14%           
  Complexity      296      296           
=========================================
  Files            39       39           
  Lines           971      971           
=========================================
  Hits            953      953           
  Misses           18       18           
Files with missing lines Coverage Δ
src/CaptainHook/ValidateConventionalCommit.php 100.00% <100.00%> (ø)

Copy link
Owner

@ramsey ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@ramsey ramsey merged commit 8b1f120 into ramsey:main Mar 1, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve captainhook validation error message
2 participants