Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.9] Add tests for workflows shipped with the creators package #13010

Closed
wants to merge 1 commit into from
Closed

[release-2.9] Add tests for workflows shipped with the creators package #13010

wants to merge 1 commit into from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 7, 2025

Summary

Fixes #12657

Occurred changes and/or fixed issues

  • add script to do content match of creators workflows files

Tests are added in #13008

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.6 milestone Jan 7, 2025
@aalves08 aalves08 requested review from cnotv and jordojordo January 7, 2025 17:04
@aalves08 aalves08 self-assigned this Jan 7, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.9.6, v2.11.0 Jan 7, 2025
cnotv
cnotv approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordojordo
Copy link
Member

Closing in favor of #13008

@jordojordo jordojordo closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordojordo jordojordo jordojordo approved these changes

@cnotv cnotv cnotv approved these changes

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aalves08 @jordojordo @cnotv