Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Providers: Add search_using_service_account field #13223

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

cnotv
Copy link
Member

@cnotv cnotv commented Jan 28, 2025

Summary

Fixes #12871

Occurred changes and/or fixed issues

Added checkbox with field searchUsingServiceAccount only if type is openldap or freeipa.

Technical notes summary

  • Added checkbox and i18n
  • Created new unit test for the view to ensure the checkbox

Areas or cases that should be tested

  • Auth provider configuration with OpenLDAP, search "Setting up an OpenLDAP Auth Provider on Rancher Dashboard for testing" in Confluence if needed
  • Member search on Cluster member configuration

Areas which could experience regressions

Screenshot/Video

Configuration checkbox

Screenshot 2025-01-28 at 20 05 55

Payload submission

Screenshot 2025-01-28 at 19 48 43

User search

Screenshot 2025-01-28 at 20 03 36

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@cnotv cnotv marked this pull request as ready for review January 29, 2025 14:56
@cnotv cnotv requested a review from rak-phillip January 29, 2025 15:08
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'm considering if we should add a tooltip to explain what the option does. I was thinking something along the lines of

When enabled, Rancher will use the service account instead of the user account to search for users and groups.

What do you think?

@cnotv
Copy link
Member Author

cnotv commented Jan 30, 2025

Looks great. I'm considering if we should add a tooltip to explain what the option does. I was thinking something along the lines of

When enabled, Rancher will use the service account instead of the user account to search for users and groups.

What do you think?

More clarity is always welcome in my book, good suggestion 👍

@cnotv cnotv requested a review from rak-phillip January 30, 2025 17:50
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnotv cnotv merged commit 85c31a4 into rancher:master Jan 30, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Providers: Add search_using_service_account field
2 participants