Resolving a reference to an undefined lockedExist and adding for project memberships with custom permissions
#13543
+78
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for project memberships with custom permissions Fixes rancher#12828
codyrancher
commented
Feb 28, 2025
| @@ -194,7 +194,7 @@ export default { | |||
| return this.customPermissions.reduce((acc, customPermissionsItem) => { | |||
| const lockedExist = this.roleTemplates.find((roleTemplateItem) => roleTemplateItem.id === customPermissionsItem.key); | |||
|
|
|||
| if (lockedExist.locked) { | |||
| if (lockedExist && lockedExist.locked) { | |||
There was a problem hiding this comment.
This line is the actual fix. Everything else is just instrumenting/testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolving a reference to an undefined
lockedExistand adding for project memberships with custom permissionsFixes #12828
Occurred changes and/or fixed issues
Really just correcting an undefined reference.
Technical notes summary
The majority of this change is adding the infrastructure to write a test
Areas or cases that should be tested
Adding project members with custom permissions. You can add them from the
Cluster and Project memberspage or from theProjectedit page.Screenshot/Video
project-member-custom-permissions.mp4
Checklist