Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MySQL Galera Cluster #1103

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Added MySQL Galera Cluster #1103

merged 1 commit into from
Feb 4, 2025

Conversation

abychko
Copy link
Contributor

@abychko abychko commented Jan 28, 2025

codership/mysql-galera:
- 0.3.0

@abychko abychko requested a review from a team as a code owner January 28, 2025 12:06
@recena recena requested a review from troytop January 28, 2025 12:08
@recena recena changed the title Added chart versions: Added Galera Cluster Jan 28, 2025
@recena recena changed the title Added Galera Cluster Added MySQL Galera Cluster Jan 28, 2025
@recena
Copy link
Collaborator

recena commented Jan 28, 2025

@abychko Do you work at Codership?

@abychko
Copy link
Contributor Author

abychko commented Jan 28, 2025

@abychko Do you work at Codership?

yes, I work at Codership

adamkpickering
adamkpickering requested changes Jan 30, 2025
View reviewed changes
packages/codership/mysql-galera/overlay/app-readme.md Show resolved Hide resolved
packages/codership/mysql-galera/overlay/app-readme.md Outdated
## Installation
- Plan your cluster capacity. Default is 3 nodes, each with 1 vCPU and 4GB of RAM, the storage is 2GB. It is minimal requirement for Galera to work.
- Specify a new namespace for the MySQL Galera cluster, like `mysql-galera`.
- Install the MySQL Galera chart.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bullet points are indented too much. The result is that this appears as a code block:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the wrong indentation

@abychko abychko force-pushed the main-source branch 8 times, most recently from e0b2c12 to 399c51b Compare February 3, 2025 10:58
@abychko
Copy link
Contributor Author

abychko commented Feb 3, 2025

updated PR, added links to Galera Cluster site, Helm chart post and general documentation. tested markdown in rancher

adamkpickering
adamkpickering previously approved these changes Feb 3, 2025
View reviewed changes
@adamkpickering
Copy link
Collaborator

@abychko there is a merge conflict. I tried to resolve it and push codership:main-source, but it looks like permissions on that repo are configured so that I can't.

Can you please either rebase this branch on the the latest main-source from this repo, or remove the change to line that modifies the generated: ... line from index.yaml? That will resolve the merge conflict, which will allow us to merge this PR.

Thanks!

@abychko
Added chart versions:
daa672c 
  codership/mysql-galera:
    - 0.3.0
@abychko
Copy link
Contributor Author

abychko commented Feb 4, 2025

hello! PR has been rebased on latest main-source, conflicting line is fixed now

@byte
Copy link

byte commented Feb 4, 2025

looks like this is ready to merge @adamkpickering ? very excited

@adamkpickering adamkpickering merged commit c38d9d6 into rancher:main-source Feb 4, 2025
1 check passed
@adamkpickering
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkpickering adamkpickering adamkpickering approved these changes

@troytop troytop Awaiting requested review from troytop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abychko @recena @adamkpickering @byte