#47091 - Added RemoteDialerProxy Helm Chart #102
Conversation
gehrkefc
changed the title
gehrkefc
changed the title
| {{- define "api-extension.name" }} | ||
| {{- default "api-extension" .Values.apiExtensionName }} | ||
| {{- end}} |
There was a problem hiding this comment.
I'd recommend adding a quick comment in values.yaml with the default value as well since this is a non-standard value
| targetPort: https | ||
| protocol: TCP | ||
| name: https | ||
| - port: {{ .Values.service.proxyPort }} | ||
| - port: {{ default 6666 .Values.service.proxyPort }} |
There was a problem hiding this comment.
Since we have this same expression {{ default 6666 .Values.service.proxyPort }} listed across multiple files and resources, we should probably pull these port expressions into a function in _helper.yaml
| @@ -27,7 +27,7 @@ spec: | |||
| {{- end }} | |||
| serviceAccountName: {{ include "remotedialer-proxy.serviceAccountName" . }} | |||
| containers: | |||
| - name: {{ .Chart.Name }} | |||
| - name: {{ include "remotedialer-proxy.name" . }} | |||
There was a problem hiding this comment.
Is there a reason we need to change the name of the container here?
| {{/* | ||
| API Extension Name - To be used in other variables | ||
| */}} | ||
| {{- define "api-extension.name" }} |
There was a problem hiding this comment.
I'm having a hard time figuring out why we need to have this function. Looks like its mostly wrapped inside of a bunch of other functions and is used the same way that .Chart.Name is usually used.
| replicaCount: 1 | ||
|
|
||
| image: | ||
| repository: rancher |
There was a problem hiding this comment.
For images the repository refers to the full name of the image (ex rancher/rancher-webook). This should be rancher/remotedialer-proxy
Issue: rancher/rancher#47091
This depends on: rancher/rancher#47037
Problem
We had to convert the kubernetes files in 47037 into helm charts.
Solution
Added RemoteDialer Proxy Helm Chart