Run Handlers When Services Should Exist #280
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `rke2-*` services might not exist so make sure to check if they should be there prior to trying to reset them. * `rke2_installed_version` is not defined prior to use. default it to an empty string.
|
Thanks @timway ! I'm going to create a new issue to adjust the tarball logic to prevent this from happening in the first place! We'll get that taken care of and pushed into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rke2-*services might not exist so make sure to check if they should be there prior to trying to reset them.rke2_installed_versionis not defined prior to use. default it to an empty string.What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
The role fails to restart services during a tarball install because it tries to restart services for both
rke2-serverandrke2-agentregardless of what was installed.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #275
Testing
Tested on SLES15 SP6 VMs created by Terraform against a cloud-init based image on vSphere in our CI.
Release Notes
(REQUIRED)