Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a prop to the tooltip component for collision padding #932

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Ikari-Shinji-re
Copy link
Member

@Ikari-Shinji-re Ikari-Shinji-re commented Nov 4, 2024

Summary

Collision padding refers to the space that is added around the tooltip to ensure that it does not collide with the edges of its container or other UI elements. This padding helps to prevent the tooltip from being positioned too close to the boundaries of the viewport or overlapping with other components, which can enhance usability and visibility.

Fixes # (issue)

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

@Ikari-Shinji-re Ikari-Shinji-re force-pushed the feat/add-collision-padding-to-tooltip-component branch from 5ea76f3 to ada729d Compare November 4, 2024 06:47
@Ikari-Shinji-re Ikari-Shinji-re changed the title feat: add a collision padding prop to the Tooltip component feat: add a prop to the tooltip component for collision padding Nov 4, 2024
@Ikari-Shinji-re Ikari-Shinji-re marked this pull request as ready for review November 4, 2024 06:48
@RanGojo RanGojo self-requested a review November 4, 2024 07:00
@RanGojo RanGojo merged commit f7dae29 into next Nov 4, 2024
5 checks passed
@RanGojo RanGojo deleted the feat/add-collision-padding-to-tooltip-component branch November 4, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants