Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind GRN_OP_FUZZY #125

Merged
merged 1 commit into from
Mar 5, 2016
Merged

Bind GRN_OP_FUZZY #125

merged 1 commit into from
Mar 5, 2016

Conversation

myokoym
Copy link
Member

@myokoym myokoym commented Mar 5, 2016

GitHub: #116

GRN_OP_MATCHなどはGroonga::Operator::MATCH.execgrn_operator_exec_matchを呼んでいますが、
GRN_OP_FUZZYもGroonga側でgrn_operator_exec_fuzzy公開してもらったほうがよいですか?
必要かどうかよくわかっていません。

kou added a commit that referenced this pull request Mar 5, 2016
Bind GRN_OP_FUZZY

Patch by Masafumi Yokoyama. Thanks!!!
@kou kou merged commit fa0035c into master Mar 5, 2016
@kou kou deleted the bind-grn-op-fuzzy branch March 5, 2016 15:04
@kou
Copy link
Member

kou commented Mar 5, 2016

Groonga::Operator::FUZZY.execは必要ありませんが、selectの中でrecord.column.fuzzy(...)と書けるようにしないと、ユーザーは使えないんじゃないかなぁと思っています。

@kou
Copy link
Member

kou commented Mar 6, 2016

あ、これは難しいので私がやります。
なので、気にしないでいいです。

@myokoym
Copy link
Member Author

myokoym commented Mar 6, 2016

わかりました。よろしくお願いします。

@kou
Copy link
Member

kou commented Mar 6, 2016

record.key.fuzzy_search("Toym") とは書けるようにしましたが、record.key.fuzzy_search("Toym", :with_transposition => true)と書けるようにするのは6.0.1にします。Groonga側の修正も必要で、その修正がGroonga 6.0.1で入るからです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants