Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerances New PR #161

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Tolerances New PR #161

wants to merge 15 commits into from

Conversation

Sondar74
Copy link
Contributor

@Sondar74 Sondar74 commented Sep 5, 2023

New PR with tolerances.
Added absolute tolerance for isapprox() and exact comparison for Rational inputs.
New PR with one test for a RK method with Floating Inputs obtained from MatLab. Also, the non-broken tests for the AVF method passed.

Copy link
Owner

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Also, the non-broken tests for the AVF method passed.

Do you mean that a previously broken test passes now? This is great! Could you please adapt the test accordingly?

Copy link
Owner

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your patience. We're almost there

Sondar74 and others added 3 commits September 12, 2023 11:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Hendrik Ranocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants