Use a requests session per FinTSHTTPSConnection #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a requests session per FinTSHTTPSConnection. This mostly results in requests reusing the HTTPS connection, leading to fewer roundtrips and lower latency overall. It would also allow cookie sharing, etc., but I don't think that matters at all for any FinTS stuff. Given that it's also an isolated session per FinTSHTTPSConnection, I don't see how this could have a negative impact.
Tested with my bank.