LEDO-125: Adding support for Jenkins in EKS #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cog-ruby into LEDO-125-jenkins-eks-migration
recog.gemspec
Outdated
| gem_public_cert = ENV['GEM_PUBLIC_CERT'] | ||
| gem_private_key = ENV['GEM_PRIVATE_KEY'] | ||
|
|
||
| if !gem_public_cert.nil? && !gem_private_key.nil? |
There was a problem hiding this comment.
not nil is sorta a double negative. I think you can just do
if gem_public_cert && gem_private_key
There was a problem hiding this comment.
@pdeardorff-r7's guidance is in alignment with
RuboCop: No non-nil Checks.
There was a problem hiding this comment.
Ah, I tested both usages locally and saw mention that there may be some differences between them. so thought adding the nil check would be safer. Thanks for pointing that out!
adungo-r7
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the recog submodule to use HTTPS, as the current Jenkins implementation does not appear to support SSH, and was preventing it from pulling the repo.
Updates the recog submodule and also adds the ability to define the locations for a public cert and private key used for signing. Then the version has also been automatically bumped due to testing the release process.
Motivation and Context
These changes help support the new Jenkins release process. The new approach uses self-signed certs.
https://issues.corp.rapid7.com/browse/LEDO-125
How Has This Been Tested?
The actual job being ran is present within an internal shared-library, and is able to run on each branch independently. So was able to run and validate each stage of the job from this branch.
Types of changes
Checklist: