Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if both ground truth and result are NaN in MSEObjectiveTest for RF #6387

Open
wants to merge 4 commits into
base: branch-25.04
Choose a base branch
from
Open

Check if both ground truth and result are NaN in MSEObjectiveTest for RF #6387

wants to merge 4 commits into from

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Mar 3, 2025

If both results are NaNs, pass the test rather than attempting to ASSERT_NEAR on NaN values.

@wphicks wphicks requested a review from a team as a code owner March 3, 2025 19:25
@wphicks wphicks requested review from tfeher and lowener March 3, 2025 19:25
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Mar 3, 2025
@github-actions github-actions bot added CUDA/C++ and removed bug Something isn't working non-breaking Non-breaking change labels Mar 3, 2025
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

@tfeher tfeher Awaiting requested review from tfeher tfeher is a code owner automatically assigned from rapidsai/cuml-cpp-codeowners

@lowener lowener Awaiting requested review from lowener lowener is a code owner automatically assigned from rapidsai/cuml-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wphicks @csadorf @jcrist