-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new KvikIO compatibility mode "AUTO" #547
base: branch-24.12
Are you sure you want to change the base?
Add a new KvikIO compatibility mode "AUTO" #547
Conversation
69660c6
to
6557e56
Compare
4884ccf
to
db89849
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @kingcrimsontianyu but I am wondering if we should use the CompatMode
enum instead of a string throughout?
I'm still debating on this. My thought is that no matter what value the user specifies (via the environment variable or PS: If we decide to expose |
I have no strong opinion, but leaning towards exposing
No, I don't think that is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @kingcrimsontianyu! Could you also update the C++ docs and the Python docs ?
/ok to test |
1 similar comment
/ok to test |
/ok to test |
1 similar comment
/ok to test |
5e38233
to
ca4bf22
Compare
Created #556 to improve our testing on GDS/POSIX I/O code in the future. |
This PR addresses issue #529. A new compatibility mode
AUTO
(previously proposed asALLOW
) is added that explicitly asks KvikIO to determine whetherON
orOFF
is eventually used for the I/O.Closes #529