Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SparkFun ThingPlus RP2350 #2038

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add SparkFun ThingPlus RP2350 #2038

wants to merge 2 commits into from

Conversation

sfe-SparkFro
Copy link

Upcoming board from us!

peterharperuk
peterharperuk reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@peterharperuk peterharperuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the default cyw43 pins.

@lurch lurch self-requested a review November 13, 2024 19:27
@lurch
Copy link
Contributor

lurch commented Nov 13, 2024

LGTM, but I guess this might need a

// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1

line to satisfy the upcoming #2034 ? ping @will-v-pi

@will-v-pi
Copy link

LGTM, but I guess this might need a

// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1

line to satisfy the upcoming #2034 ? ping @will-v-pi

Yeah, that’d be good, so I don’t have to rebase #2034 on top of this to add it

@sfe-SparkFro
Copy link
Author

Done!

@sfe-SparkFro sfe-SparkFro mentioned this pull request Nov 14, 2024
Merged
earlephilhower
earlephilhower reviewed Nov 15, 2024
View reviewed changes
src/boards/include/boards/sparkfun_thingplus_rp2350.h

// gpio pin for spi data out to the cyw43 chip
#ifndef CYW43_DEFAULT_PIN_WL_DATA_OUT
#define CYW43_DEFAULT_PIN_WL_DATA_OUT 24u
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just looking at this as part of the update for CYW43 support in arduino-pico on the RP2350 boards, so maybe I'm missing something, but are data_in, data_out, and host_wake all on pin 24?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Theoretically any GPIO pins can be used (see here: #1938 (comment)), but Raspberry Pi managed to cleverly connect all 3 pins of the radio to a single GPIO pin on the host processor. For reference, see the Pico W datasheet (schematic on page 23). This board uses the same connections with the same resistors to avoid contention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_driver/cyw43_bus_pio_spi.c is where the software-side magic works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterharperuk peterharperuk peterharperuk left review comments

@lurch lurch lurch approved these changes

@earlephilhower earlephilhower earlephilhower left review comments

Assignees
No one assigned
Labels
board settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfe-SparkFro @lurch @will-v-pi @earlephilhower @peterharperuk