Add additional Bazel config tinyUSB and pico_stdio_usb #2264
Conversation
|
I chatted with @armandomontanez on Friday and I'm going to upload a narrower patch based on his feedback. |
mbrase
force-pushed
the
pico-shared-usb
branch
from
d878d50 to
1bf7317
Compare
|
I've uploaded a new patch which is a subset of the previous patch Add Bazel label flag for overriding tusb_config.h This adds |
mbrase
changed the title
This adds `//bazel/config:PICO_TINYUSB_CONFIG`, which is used to select which tusb_config.h gets linked into the tinyUSB port. This defaults to the tusb_config.h from the pico_stdio_usb (same as before), but allows Bazel users to override this config with their own.
mbrase
force-pushed
the
pico-shared-usb
branch
from
1bf7317 to
8669b97
Compare
|
Hi, I'm ready for this to be reviewed |
| @@ -43,10 +46,6 @@ cc_library( | |||
| hdrs = ["include/pico/stdio_usb.h"], | |||
| includes = ["include"], | |||
| target_compatible_with = compatible_with_rp2(), | |||
| visibility = [ | |||
There was a problem hiding this comment.
Publicly exposing this is a little unfortunate, but it's probably the only path forward anyway.
There was a problem hiding this comment.
Yeah, I wanted to include the stdio_usb.h in my tusb_config.h, much like the default tusb_config.h does, and I need the header only target to avoid a circular dependency.
|
Bazel changes look good to me, sorry for the dealy. |
This change the makes the following defines setable in Bazel:
LIB_TINYUSB_HOSTLIB_TINYUSB_DEVICEPICO_STDIO_USB_ENABLE_RESET_VIA_BAUD_RATEPICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACEThis also adds
//bazel/config:PICO_TINYUSB_CONFIG, which allows overriding the "tusb_config.h" header used to build tinyUSB. This might be used to add additional USB interfaces while preserving the functionality from pico_stdio_usb.