Add SPARE_IRQs to the SVD #2271
Conversation
…e with a size of zero is not a legal SVD, so including something hopefully harmless
…competing #defines as these were called USER_IRQs in the SDK 1.x
|
Note, i have not added the extra IRQs to the RP2040 SVD as i don't know if that is rocking the boat too much (as i'd have to change the |
|
cc @jonathanpallant, @pta2002, @jannic not sure if i want to risk making this change at the last hour for 2.1.1 - LMK... if i don't see lots of happy faces, I'll push it to 2.1.2 |
| @@ -71,6 +71,12 @@ typedef enum irq_num_rp2040 { | |||
| I2C0_IRQ = 23, ///< Select I2C0's IRQ output | |||
| I2C1_IRQ = 24, ///< Select I2C1's IRQ output | |||
| RTC_IRQ = 25, ///< Select RTC's IRQ output | |||
| SPARE_IRQ_0 = 26, ///< Select SPARE IRQ 0 | |||
There was a problem hiding this comment.
Comparing this to https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2350/hardware_regs/include/hardware/regs/intctrl.h , do these spare IRQs also need to be added to the #ifdef __ASSEMBLER__ section?
There was a problem hiding this comment.
Hmmm, just noticed that https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2350/hardware_regs/include/hardware/regs/intctrl.h also has:
#define PLL_USB_IRQ 43
#define POWMAN_IRQ_POW 44
#define POWMAN_IRQ_TIMER 45
#define SPAREIRQ_IRQ_0 46
#define SPAREIRQ_IRQ_1 47and
PLL_USB_IRQ = 43, ///< Select PLL_USB's IRQ output
POWMAN_IRQ_POW = 44, ///< Select POWMAN's IRQ_POW output
POWMAN_IRQ_TIMER = 45, ///< Select POWMAN's IRQ_TIMER output
SPARE_IRQ_0 = 46, ///< Select SPARE IRQ 0
SPARE_IRQ_1 = 47, ///< Select SPARE IRQ 1with the naming of SPAREIRQ_IRQ_0 vs. SPARE_IRQ_0 seeming to be a bit inconsistent? 🤔
fixes #1898