Add new feature defines to pico_stdio_usb #2296
Open
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the following to pico_stdio_usb: - `PICO_STDIO_USB_ENABLE_IRQ_BACKGROUND_TASK` - `PICO_STDIO_USB_ENABLE_TINYUSB_INIT` - `PICO_STDIO_USB_USE_DEFAULT_DESCRIPTORS` These defines replace some ifdefs that were previously gated by the `LIB_TINYUSB_DEVICE` define and will allow finer grained control. All of these defines default to 1 if LIB_TINYUSB_DEVICE is not defined and 0 if LIB_TINYUSB_DEVICE is defined, which should preserve the old behavior.
|
|
||
| // PICO_CONFIG: PICO_STDIO_USB_ENABLE_TINYUSB_INIT, Enable/disable calling tinyUSB tusb_init() during initialization, default=1 if the application is not using tinyUSB directly, group=pico_stdio_usb | ||
| #ifndef PICO_STDIO_USB_ENABLE_TINYUSB_INIT | ||
| #if !defined(LIB_TINYUSB_HOST) && !defined(LIB_TINYUSB_DEVICE) |
There was a problem hiding this comment.
Copying from other PR:
These are the only instances in the Pico SDK that use #if defined(LIB_*), I suspect they were intended to be #if LIB_*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following to pico_stdio_usb:
PICO_STDIO_USB_ENABLE_IRQ_BACKGROUND_TASKPICO_STDIO_USB_ENABLE_TINYUSB_INITPICO_STDIO_USB_USE_DEFAULT_DESCRIPTORSThese defines replace some ifdefs that were previously gated by the
LIB_TINYUSB_DEVICEdefine and will allow finer grained control. All of these defines default to 1 if LIB_TINYUSB_DEVICE is not defined and 0 if LIB_TINYUSB_DEVICE is defined, which should preserve the old behavior.