Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcm2835: consistent signal names. #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gadgetoid
Copy link

@Gadgetoid Gadgetoid commented Jun 17, 2024

I guess these are... weird... because either:

  1. The datasheet done it, who are we to argue with peripheral signal nomenclature?
  2. pinctl is now a critical part of some infrastructure and changing signal names will cause nuclear meltdown
  3. It's too much like hard work to rename things now, it's all indented so pretty and such

On the off chance it's no 3, here's a PR to rename things like SDA0 to I2C0_SDA so there aren't two alt mode pin naming schemes coexisting, ending up in my board documentation files, and making my website look ugly.

IMHO things like SAn and SDn could stand to be prefixed with SMI and if I were being really pedantic (and assuming I'm not horribly wrong) things like ARM_TRST changed to JTAG_TRST.

Is this petty and unnecessary? Yes.

Could I sleep if I didn't raise this PR? No.

Rename SDAn to I2Cn_SDA, etc.

Rename CTSn to UARTn_CTS, etc.

Signed-off-by: Phil Howard <[email protected]>
@pelwell
Copy link
Collaborator

pelwell commented Jun 18, 2024

The names have all been derived from the respective datasheets, with a degree of automated regularisation. Of those potential reasons for maintaining the status quo, it's 2 that worries me the most.

I hope that writing this PR has the same effect as writing a letter but not sending it, because without further encouragement I'm not planning on merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants