Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess these are... weird... because either:
On the off chance it's no 3, here's a PR to rename things like
SDA0
toI2C0_SDA
so there aren't two alt mode pin naming schemes coexisting, ending up in my board documentation files, and making my website look ugly.IMHO things like
SAn
andSDn
could stand to be prefixed withSMI
and if I were being really pedantic (and assuming I'm not horribly wrong) things likeARM_TRST
changed toJTAG_TRST
.Is this petty and unnecessary? Yes.
Could I sleep if I didn't raise this PR? No.