[RayService] Always create RayService services and remove RayServiceInitializing #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
refactor-rayservice-alwayssvc
branch
6 times, most recently
from
b90ee6c to
dde1cad
Compare
rueian
commented
Jan 31, 2025
| @@ -222,7 +222,7 @@ func BuildServeService(ctx context.Context, rayService rayv1.RayService, rayClus | |||
|
|
|||
| if isRayService { | |||
| // We are invoked from RayService | |||
| if len(ports) == 0 && rayService.Spec.ServeService == nil { | |||
| if len(ports) == 0 && rayService.Spec.ServeService == nil && rayCluster.Name != "" { | |||
There was a problem hiding this comment.
rayCluster.Name != "" is essential for building a service without RayCluster.
| message := "RayService is initializing" | ||
| setCondition(rayServiceInstance, rayv1.RayServiceReady, metav1.ConditionFalse, rayv1.RayServiceInitializing, message) | ||
| setCondition(rayServiceInstance, rayv1.UpgradeInProgress, metav1.ConditionFalse, rayv1.RayServiceInitializing, message) | ||
| } |
There was a problem hiding this comment.
Remove RayServiceInitializing for simplicity.
| case utils.ServingService: | ||
| newSvc, err = common.BuildServeServiceForRayService(ctx, *rayServiceInstance, *rayClusterInstance) | ||
| if rayClusterInstance == nil { |
There was a problem hiding this comment.
Make it clear that rayClusterInstance could be nil.
| } | ||
|
|
||
| // Retrieve the Service from the Kubernetes cluster with the name and namespace. | ||
| oldSvc := &corev1.Service{} | ||
| err = r.Get(ctx, client.ObjectKey{Name: newSvc.Name, Namespace: rayServiceInstance.Namespace}, oldSvc) | ||
|
|
||
| if err == nil { | ||
| // Do not drop cluster selector on the existing service. | ||
| if newSvc.Spec.Selector[utils.RayClusterLabelKey] == "" { |
There was a problem hiding this comment.
Do not change the existing cluster selector to "" for not dropping requests.
…nitializing Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
refactor-rayservice-alwayssvc
branch
from
dde1cad to
4450ec6
Compare
kevin85421
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, the RayService controller only creates k8s services for RayService when the RayServe is ready. This PR changes the behavior to create k8s services first even when the RayServe is not ready, and later, the selector is updated to the ready RayServe. The new behaivor will help users expose k8s services as soon as possible.
Related issue number
Checks