[image] remove azure packages from base image #48762
Conversation
|
fixes #48733 |
aslonnie
force-pushed
the
lonnie-241115-killazure
branch
from
18cacc8
to
f0a4dcb
Compare
| head_setup_commands: [] | ||
| # - pip install -U azure-cli-core==2.22.0 azure-mgmt-compute==14.0.0 azure-mgmt-msi==1.0.0 azure-mgmt-network==10.2.0 azure-mgmt-resource==13.0.0 | ||
| - pip install -U azure-cli-core==2.22.0 azure-mgmt-compute==14.0.0 azure-mgmt-msi==1.0.0 azure-mgmt-network==10.2.0 azure-mgmt-resource==13.0.0 |
There was a problem hiding this comment.
is this 2.22.0 what we expect? in docker/base-deps/Dockerfile we deleted a 2.40.0
There was a problem hiding this comment.
I have no idea.. I am waiting for someone to tell me which one to use.
There was a problem hiding this comment.
I think even azure-cli-core==2.62.0 is too old since it brings an old paramiko==2.12.0. What about we use the latest version now?
There was a problem hiding this comment.
I would guess this thing is 70% chance broken already even without the change.
I just want to remove the ones in the base image, and I am uncommenting this line just as a courtesy. please feel free to changes these to the right version core team thinks this should be, but maybe in a follow up?
or let me the exact line I should put here, and I will just copy it here..
There was a problem hiding this comment.
another idea can be, I can just drop all the versions constraints.. and let pip figure it out by itself...
There was a problem hiding this comment.
ok, I am changing it to be consistent with https://github.com/ray-project/ray/blob/master/python/ray/autoscaler/azure/defaults.yaml#L139
if that one does not work, I am claiming that it is not my fault..
There was a problem hiding this comment.
cool. We can also ask @gramhagen to take a look
too ancient; and there are no tests. Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-241115-killazure
branch
from
f0a4dcb
to
9d9e063
Compare
|
shall I merge this? |
I can merge myself. thanks. |
too ancient; and there are no tests.
this should remove the outdated paramiko package from the ray image