Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add more missing implementations to SDL #3436

Merged
merged 6 commits into from Oct 18, 2023
Merged

[core] Add more missing implementations to SDL #3436

merged 6 commits into from Oct 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2023

Changes

  1. Adds ShowCursor implementation (R469-R471).
  2. Adds HideCursor implementation (R477-R479).
  3. Adds EnableCursor implementation (R485-R486).
  4. Adds DisableCursor implementation (R494).
  5. Adds SetClipboardText implementation (R455).
  6. Adds GetClipboardText implementation (R459, R462).
  7. Adds SetMouseCursor implementation (R65, R182-R196, R560-R563, R819).
  8. Adds SetWindowFocused implementation (R335).
  9. Adds GetMonitorPhysicalWidth implementation (R409-R425).
  10. Adds GetMonitorPhysicalHeight implementation (R431-R447).
  11. Adds GetWindowHandle implementation (R341).
  12. Adds SetGamepadMappings implementation (R575).

Notes

  • I don't have a joystick/controller here right now, so I couldn't test SetGamepadMappings.

Environment

Tested this changes successfully on Linux (Ubuntu 22.04 64-bit, gcc 11.2.0) with SDL2 (2.28.4).

Edits

1: added line marks.
2, 3, 4, 5, 6: added more implementations.

@ghost
Copy link
Author

ghost commented Oct 18, 2023

@raysan5 I think it's ready for merging. 👍

@raysan5 raysan5 merged commit d0a265c into raysan5:master Oct 18, 2023
12 checks passed
@raysan5
Copy link
Owner

raysan5 commented Oct 18, 2023

@ubkp Great! Thanks for the additions! 👍🙂

@ghost ghost deleted the add/implementations branch October 18, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant