Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap errors for database repositories #829

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: wrap errors for database repositories #829

merged 2 commits into from
Dec 16, 2024

Conversation

kushsharma
Copy link
Member

Errors were joined as string causing callers to unwrap error incorrectly.

Errors were joined as string causing callers to unwrap error
incorrectly.

Signed-off-by: Kush Sharma <[email protected]>
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 2:17am

@kushsharma kushsharma marked this pull request as ready for review December 9, 2024 04:35
@kushsharma kushsharma enabled auto-merge (squash) December 9, 2024 04:39
@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12344651470

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 134 (1.49%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/billing_checkout_repository.go 0 1 0.0%
internal/store/postgres/billing_product_repository.go 0 1 0.0%
internal/store/postgres/billing_subscription_repository.go 0 1 0.0%
internal/store/postgres/group_repository.go 0 1 0.0%
internal/store/postgres/billing_price_repository.go 0 2 0.0%
internal/store/postgres/billing_transactions_repository.go 0 2 0.0%
internal/store/postgres/session_repository.go 0 2 0.0%
internal/store/postgres/webhook_endpoint_repository.go 0 2 0.0%
internal/store/postgres/organization_repository.go 0 4 0.0%
internal/store/postgres/role_repository.go 0 6 0.0%
Totals Coverage Status
Change from base Build 12344633287: 0.0%
Covered Lines: 7667
Relevant Lines: 25201

💛 - Coveralls

@ravisuhag ravisuhag disabled auto-merge December 16, 2024 02:17
@ravisuhag ravisuhag merged commit 728edc1 into main Dec 16, 2024
6 of 7 checks passed
@ravisuhag ravisuhag deleted the db-error-wrap branch December 16, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants