Fix submission on last day of grace period and close cohort 6 #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same bug as days_remaining_before_submission
mbarton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172
Undo the hot fixes we did to quickly unblock submission on the last day of the grace period (#1163, #1164, #1165) and the underlying bugs:
days_remaining_before_submissionshould be inclusive of the last day of the grace periodsubmitting_cohortwas a number so we couldn't getcohort_start_datefrom it, we neededsubmitting_cohort_start_dateThis will have the effect of closing out cohort 6 so will only merge after our extended deadline (Sunday 19th Jan).
Also removes the "0 days remaining" for cohort 6 on the homepage.
Finally as a side effect also fixes #1176