Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions on discord, I'm adding
libmem-config.cmake
.Suggesting its use via
FetchContent
implies carefully maintaining its compatibility over time and not introducing breaking changes.I suggest creating a dedicated tag, named
config-v1
that would track non-breaking updates of this config file.In this case, the suggested config URL would be:
https://raw.githubusercontent.com/rdbo/libmem/config-v1/libmem-config.cmake
(instead of relying on the master branch with:https://raw.githubusercontent.com/rdbo/libmem/master/libmem-config.cmake
).And if we ever had to do a breaking change, the
config-v1
tag would be frozen, in favor ofconfig-v2
, etc.Also, a version is mentioned in the file (
Config version: 2023-12-10.0
).I think this is important because some people will make a copy of the config rather than using
FetchContent
.In this case, this will at least let know which exact version was used.
I'm ready to make changes if requested.
To update an existing tag without affecting other tags:
git tag -f config-v1 && git push -f origin config-v1
I mention this because it is often suggested to use
, which can be problematic if other tags have been modified locally.git push -f --tags