CBR2-2108: MaxAssociatedDevices and BssMaxNumSta having incorrect con… #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figs
Reason for change: MaxAssociatedDevice observed to be 15.
Test Procedure: Executing the below mentioned dmcli command.
1. Device.WiFi.AccessPoint.6.MaxAssociatedDevices
2. Device.WiFi.AccessPoint.6.X_CISCO_COM_BssMaxNumSta
3. Device.WiFi.AccessPoint.10.MaxAssociatedDevices
4. Device.WiFi.AccessPoint.10.X_CISCO_COM_BssMaxNumSta
Priority: P1
Risks: Low
Signed-off-by: [email protected]
gsathish86
requested changes
Feb 5, 2025
source/db/wifi_db_apis.c
Outdated
| @@ -6623,8 +6623,13 @@ int wifidb_init_vap_config_default(int vap_index, wifi_vap_info_t *config, | |||
| #else | |||
| if (isVapPrivate(vap_index)) { | |||
| cfg.u.bss_info.bssMaxSta = wifi_hal_cap_obj->wifi_prop.BssMaxStaAllow; | |||
| wifi_util_info_print(WIFI_DB, "%s:%d vap_index:%d maxassoc:%d", __func__, __LINE__, vap_index, cfg.u.bss_info.bssMaxSta); | |||
| } else if (isVapHotspotOpen5g(vap_index) || isVapHotspotSecure5g(vap_index)) { | |||
| cfg.u.bss_info.bssMaxSta = 15; | |||
There was a problem hiding this comment.
Have 15 as a define macro in wifi_base.h file
source/db/wifi_db_apis.c
Outdated
| @@ -6623,8 +6623,13 @@ int wifidb_init_vap_config_default(int vap_index, wifi_vap_info_t *config, | |||
| #else | |||
| if (isVapPrivate(vap_index)) { | |||
| cfg.u.bss_info.bssMaxSta = wifi_hal_cap_obj->wifi_prop.BssMaxStaAllow; | |||
| wifi_util_info_print(WIFI_DB, "%s:%d vap_index:%d maxassoc:%d", __func__, __LINE__, vap_index, cfg.u.bss_info.bssMaxSta); | |||
| } else if (isVapHotspotOpen5g(vap_index) || isVapHotspotSecure5g(vap_index)) { | |||
| cfg.u.bss_info.bssMaxSta = 15; | |||
There was a problem hiding this comment.
By this code, 15 is set as MaxSta for both commercial and residential platforms. For residential it should be 5 and for commercial it is 15.
…figs
Reason for change: MaxAssociatedDevice observed to be 15.
Test Procedure: Executing the below mentioned dmcli command.
1. Device.WiFi.AccessPoint.6.MaxAssociatedDevices
2. Device.WiFi.AccessPoint.6.X_CISCO_COM_BssMaxNumSta
3. Device.WiFi.AccessPoint.10.MaxAssociatedDevices
4. Device.WiFi.AccessPoint.10.X_CISCO_COM_BssMaxNumSta
Priority: P1
Risks: Low
Signed-off-by: [email protected]
MothiShree
force-pushed
the
bssmaxsta_sprint
branch
from
add2f41 to
4dc4b41
Compare
…figs
Reason for change: MaxAssociatedDevice observed to be 15.
Test Procedure: Executing the below mentioned dmcli command.
1. Device.WiFi.AccessPoint.6.MaxAssociatedDevices
2. Device.WiFi.AccessPoint.6.X_CISCO_COM_BssMaxNumSta
3. Device.WiFi.AccessPoint.10.MaxAssociatedDevices
4. Device.WiFi.AccessPoint.10.X_CISCO_COM_BssMaxNumSta
Priority: P1
Risks: Low
Signed-off-by: [email protected]
MothiShree
force-pushed
the
bssmaxsta_sprint
branch
from
55498f3 to
9b15ad0
Compare
gsathish86
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…figs
Reason for change: MaxAssociatedDevice observed to be 15. Test Procedure: Executing the below mentioned dmcli command.
1. Device.WiFi.AccessPoint.6.MaxAssociatedDevices
2. Device.WiFi.AccessPoint.6.X_CISCO_COM_BssMaxNumSta
3. Device.WiFi.AccessPoint.10.MaxAssociatedDevices
4. Device.WiFi.AccessPoint.10.X_CISCO_COM_BssMaxNumSta
Priority: P1
Risks: Low
Signed-off-by: [email protected]