RDKCOM-4489 RDKBDEV-2282: Support for updating configurable WAN interface to Tele… #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-4489 |
pradeeptakdas
changed the title
…covoicemanager
Reason for change:
- Update configured data interface name to telecovoicemanager.
Test Procedure: Please refer JIRA attachment for detailed test steps
Risks: None
Signed-off-by: Sherik Sensin A <[email protected]>
pradeeptakdas
force-pushed
the
RDKBDEV-2282
branch
from
c4e91fd to
a4633d1
Compare
S-Parthiban-Selvaraj
requested changes
Jan 21, 2025
| strncpy(voipIfName, DEFAULT_IFNAME, sizeof(voipIfName)); | ||
| { | ||
| #if defined(FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE) | ||
| strncpy(voipIfName, p_VirtIf->Name, sizeof(voipIfName)); |
There was a problem hiding this comment.
Can we remove FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE check and use p_VirtIf->Name as default ?
p_VirtIf->Name will always have the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…covoicemanager
Reason for change:
- Update configured data interface name to telecovoicemanager.
Test Procedure: Please refer JIRA attachment for detailed test steps
Risks: None