Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKB-58146 : [Field][INC] T-PW7 and T-PW8 "lease time remaining" valu… #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ssunil637
Copy link

…e is negative in "group_adv_cpe_information" Bizapi group

Reason for change: Dhcpv4 lease time Remaining should be zero for MAP-T
Test Procedure: Check the value of dhcpv4 lease time remaining in MAPT
Risks: Low
Priority: P1
Signed-off-by: [email protected]

…e is negative in "group_adv_cpe_information" Bizapi group

Reason for change: Dhcpv4 lease time Remaining should be zero for MAP-T
Test Procedure: Check the value of dhcpv4 lease time remaining in MAPT
Risks: Low
Priority: P1
Signed-off-by: [email protected]
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

*pInt = pDhcpc->Info.LeaseTimeRemaining;


if (pDhcpc->Info.IPAddress.Value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two versions of WanMgr_DmlDhcpcGetInfo implementation , one version sets the ip address using inet_addr
pInfo->IPAddress.Value = inet_addr(p_VirtIf->IP.Ipv4Data.ip);

inet_addr may return -1 for the invalid IP address.
Will this check satisfy those scenarios?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device should return either a valid IP address or 0.0.0.0.
root@Docsis-Gateway:~# dmcli eRT getv Device.DHCPv4.Client.1.IPAddress
CR component name is: eRT.com.cisco.spvtg.ccsp.CR
subsystem_prefix eRT.
Execution succeed.
Parameter 1 name: Device.DHCPv4.Client.1.IPAddress
type: string, value: 0.0.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants