Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Clone trait from ExtnMessage #484

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

satlead
Copy link
Collaborator

@satlead satlead commented Mar 26, 2024

What

Removes the Clone trait from Extn Messages

Why

Based on a cargo bloat Run ExtnMessage and its enums have the most size in the executable. Major contributor for this is the Clone Trait

How

Given Serialization and Deserialization is already inherent in the ExtnMessage clone trait is redundant.

Test

Run Cargo bloat again and validate the results with and without these changes

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copy link

Code Coverage

Package Line Rate Health
core.main.src.firebolt 1%
core.main.src.firebolt.handlers 2%
core.main.src.bootstrap 0%
core.main.src 0%
core.sdk.src.extn 90%
core.main.src.bootstrap.manifest 0%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.processors.events 0%
distributor.general.src 2%
core.main.src.utils 13%
core.main.src.state 19%
core.sdk.src.api.distributor 84%
device.thunder.src 0%
openrpc_validator.src 90%
core.sdk.src.api.observability 48%
core.sdk.src.api.device 59%
core.sdk.src.extn.client 91%
core.sdk.src.extn.ffi 80%
core.sdk.src.utils 53%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.client 79%
core.main.src.state.cap 44%
core.sdk.src.api 66%
core.sdk.src.api.manifest 55%
core.tdk.src.gateway 100%
core.launcher.src 0%
device.thunder_ripple_sdk.src.events 4%
core.main.src.processor 0%
core.sdk.src.api.gateway 48%
core.main.src.service.apps 43%
core.main.src.service 31%
core.sdk.src.framework 77%
core.main.src.processor.storage 0%
device.thunder_ripple_sdk.src 16%
core.main.src.service.extn 38%
core.tdk.src.utils 0%
core.launcher.src.manager 7%
core.sdk.src.api.firebolt 50%
device.thunder_ripple_sdk.src.processors 4%
core.main.src.bootstrap.extn 0%
Summary 35% (11330 / 32510)

Minimum allowed line rate is 33%

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants