Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thunderBroker migration changes with config switch #675

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

nnaveen979
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this file?

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/675/rdkcentral/Ripple

  • Commit: 6566a42

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/675/rdkcentral/Ripple

  • Commit: de029ae

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/675/rdkcentral/Ripple

  • Commit: bdf2afb

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/675/rdkcentral/Ripple

  • Commit: bdf2afb

Report detail: gist'

@rdkcmf-jenkins
Copy link

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: ok

  • Commit: bdf2afb
    '

}
}

pub fn is_subscription(&self) -> bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think is_subscription() and is_unsubscribe() are used anywhere, if not can we remove?

mut tr: Receiver<ThunderAsyncRequest>,
) -> Receiver<ThunderAsyncRequest> {
let callback = self.callback.clone();
let (mut ws_tx, mut ws_rx) = Self::create_ws(url).await;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the original websocket pool, if the websocket(s) become disconnected they reconnect and re-register any subscriptions, it doesn't look like we're doing either of those things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pahearn73 correct me if i wrong ,

  1. websocket disconnected means are we supposed to check the connection status in the loop of thunder_async_client::start fn().
  2. if the connection disconnected means we need to re-establish the web socket again with in the same thread?
  3. after re-establishing the websocket we have to send the same subscribe request made during the connection failure?
  4. i have a question that suppose i made 4 subscription requests and then connection failed then when i reconnect the websocket do i have to make those 4 subscribe requests again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: Per phone conversation will add resubscription map and logic.

Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.processors 10%
device.thunder_ripple_sdk.src.bootstrap 0%
device.mock_device.src 54%
core.main.src.service 31%
core.main.src.bootstrap.extn 0%
device.thunder_ripple_sdk.src.client 66%
core.sdk.src.framework 76%
core.main.src.bootstrap.manifest 0%
distributor.general.src 2%
device.thunder_ripple_sdk.src.events 4%
core.launcher.src 0%
core.sdk.src.extn.ffi 80%
device.thunder_ripple_sdk.src 17%
core.sdk.src.extn 83%
core.sdk.src.utils 49%
core.main.src.service.apps 47%
core.main.src.state 22%
core.main.src.firebolt 3%
core.main.src 0%
core.sdk.src.api.manifest 89%
core.main.src.state.cap 43%
core.sdk.src.extn.client 90%
device.thunder.src 0%
core.sdk.src.api.device 77%
core.launcher.src.manager 7%
core.sdk.src.api.gateway 65%
core.main.src.service.extn 40%
core.tdk.src.gateway 100%
core.tdk.src.utils 0%
device.thunder.src.bootstrap 0%
core.sdk.src.api 75%
core.main.src.utils 24%
core.sdk.src.api.observability 58%
core.main.src.broker.thunder 29%
core.main.src.processor.storage 0%
core.main.src.broker 42%
openrpc_validator.src 68%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.bootstrap 0%
core.sdk.src.api.distributor 84%
core.main.src.processor 0%
core.sdk.src.api.firebolt 77%
core.main.src.firebolt.handlers 9%
Summary 43% (19045 / 44641)

Minimum allowed line rate is 42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants