-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: thunderBroker migration changes with config switch #675
base: main
Are you sure you want to change the base?
Conversation
…etween thunderclient and thunderbroker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this file?
device/thunder_ripple_sdk/src/bootstrap/setup_thunder_pool_step.rs
Outdated
Show resolved
Hide resolved
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
chore: cleanup the commented lines of code
} | ||
} | ||
|
||
pub fn is_subscription(&self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think is_subscription()
and is_unsubscribe()
are used anywhere, if not can we remove?
mut tr: Receiver<ThunderAsyncRequest>, | ||
) -> Receiver<ThunderAsyncRequest> { | ||
let callback = self.callback.clone(); | ||
let (mut ws_tx, mut ws_rx) = Self::create_ws(url).await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the original websocket pool, if the websocket(s) become disconnected they reconnect and re-register any subscriptions, it doesn't look like we're doing either of those things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pahearn73 correct me if i wrong ,
- websocket disconnected means are we supposed to check the connection status in the loop of thunder_async_client::start fn().
- if the connection disconnected means we need to re-establish the web socket again with in the same thread?
- after re-establishing the websocket we have to send the same subscribe request made during the connection failure?
- i have a question that suppose i made 4 subscription requests and then connection failed then when i reconnect the websocket do i have to make those 4 subscribe requests again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: Per phone conversation will add resubscription map and logic.
Minimum allowed line rate is |
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist