chore: cleaning up the unnecessary functions #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahearn73
reviewed
Jan 24, 2025
| @@ -566,7 +558,7 @@ impl AppLauncher { | |||
| }, | |||
| runtime: Some(AppRuntime { | |||
| id: Some(callsign), | |||
| transport: Self::get_transport(bool_contract, &manifest.start_page), | |||
| transport: AppRuntimeTransport::Websocket, | |||
There was a problem hiding this comment.
Let's just get rid of the AppRuntimeTransport enum altogether since it's no longer needed, that will then let you also get rid of EffectiveTransport and even more code.
pahearn73
reviewed
Jan 24, 2025
| @@ -1062,23 +1018,10 @@ impl DelegatedLauncherHandler { | |||
| async fn end_session(&mut self, app_id: &str) -> Result<AppManagerResponse, AppError> { | |||
| debug!("end_session: entry: app_id={}", app_id); | |||
| let app = self.platform_state.app_manager_state.remove(app_id); | |||
| if let Some(app) = app { | |||
| if let Some(_app) = app { | |||
There was a problem hiding this comment.
This could just be if app.is_some() {.
pahearn73
reviewed
Jan 24, 2025
| thunder_device_info::ThunderDeviceInfoRequestProcessor, | ||
| thunder_events::ThunderOpenEventsProcessor, | ||
| thunder_persistent_store::ThunderStorageRequestProcessor, | ||
| thunder_remote::ThunderRemoteAccessoryRequestProcessor, |
There was a problem hiding this comment.
Did you also remove the code for the processors we no longer add on start-up?
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
removes unnecessary function code
Why
code is not used anywhere
How
cleanup the unnecessary functions in Ripple
Test
How has this been tested? How can a reviewer test it?
Checklist