Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Field Alignment #711

Merged
merged 5 commits into from
Jan 27, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Metrics Field Alignment: Fixed firmware field
pahearn73 committed Jan 13, 2025
commit 975bd7537fb1fb362f13af2452f6a469e708d581
15 changes: 11 additions & 4 deletions core/main/src/state/metrics_state.rs
Original file line number Diff line number Diff line change
@@ -26,10 +26,7 @@ use ripple_sdk::{
context::RippleContextUpdateRequest,
device::device_info_request::{DeviceInfoRequest, DeviceResponse, FirmwareInfo},
distributor::distributor_privacy::{DataEventType, PrivacySettingsData},
firebolt::{
fb_metrics::{MetricsContext, MetricsEnvironment},
fb_openrpc::FireboltSemanticVersion,
},
firebolt::{fb_metrics::MetricsContext, fb_openrpc::FireboltSemanticVersion},
gateway::rpc_gateway_api::rpc_value_result_to_string_result,
manifest::device_manifest::DataGovernanceConfig,
observability::metrics_util::ApiStats,
@@ -321,6 +318,16 @@ impl MetricsState {
*/

let mut firmware = String::default();
if let Ok(resp) = state
.get_client()
.send_extn_request(DeviceInfoRequest::FirmwareInfo)
.await
{
if let Some(DeviceResponse::FirmwareInfo(info)) = resp.payload.extract() {
firmware = info.name;
}
}

let activated = Some(true);
let proposition =
Self::get_persistent_store_string(state, PERSISTENT_STORAGE_KEY_PROPOSITION)