Skip to content

Commit

Permalink
upload: Return correct tuple values in _ProcessResults
Browse files Browse the repository at this point in the history
Incorrect tuple values were returned with http://go/grev/440221 -
instead of returning (Project, ReviewableBranch), _ProcessResults was
returning (int, ReviewableBranch).

[email protected]

Bug: 376731172
Change-Id: I75205f42fd23f5ee6bd8d0c15b18066189b42bd9
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/441121
Reviewed-by: Sam Saccone <[email protected]>
Commit-Queue: Josip Sokcevic <[email protected]>
Tested-by: Josip Sokcevic <[email protected]>
  • Loading branch information
sokcevicG authored and LUCI committed Oct 31, 2024
1 parent 1d50986 commit aada468
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions subcmds/upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,8 @@ def _ProcessResults(_pool, _out, results):
pending = []
for result in results:
project_idx, avail = result
project = projects[project_idx]
if avail is None:
project = projects[project_idx]
logger.error(
'repo: error: %s: Unable to upload branch "%s". '
"You might be able to fix the branch by running:\n"
Expand All @@ -748,7 +748,7 @@ def _ProcessResults(_pool, _out, results):
project.manifest.branch,
)
elif avail:
pending.append(result)
pending.append((project, avail))
return pending

with self.ParallelContext():
Expand Down

0 comments on commit aada468

Please sign in to comment.